Fix MCUmgr support for SHA512 hashed images #18817

de-nordic · 2024-11-12T13:05:40Z

Fix for NCSDK-30244

NordicBuilder · 2024-11-12T13:06:15Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
zephyr	nrfconnect/sdk-zephyr@`b524b0e` (main)	nrfconnect/sdk-zephyr@`c5efe1f`	nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-11-12T13:07:43Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 86580c94994554a866a9ef4bc685c3dd7cf8862a

more details

sdk-nrf:

PR head: 86580c94994554a866a9ef4bc685c3dd7cf8862a
merge base: 4739ae04e6d88cd628567511a3ef13c7310847ae
target head (main): 6495d3253ce199e481ace25251a7a8f2206cf17d
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (1)

sysbuild
│  │ CMakeLists.txt

Outputs:

Toolchain

Version: f51bdba1d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f51bdba1d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 7
✅ Integration tests
- ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
- ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_nrf_provisioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run

Note: This message is automatically posted and updated by the CI

nordicjm

commit order needs flipping, manifest update first then setting Kconfig which was added in manifest update. Also needs set_config_bool(${DEFAULT_IMAGE} CONFIG_MCUBOOT_BOOTLOADER_USES_SHA512 n) adding to the else() part to ensure it is kept in sync

NordicBuilder · 2024-11-12T13:24:23Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

NordicBuilder · 2024-11-12T15:31:46Z

Memory footprint analysis revealed the following potential issues

sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 811902[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-18817/7)

rlubos · 2024-11-13T09:45:40Z

west.yml

@@ -69,7 +69,7 @@ manifest:
    # https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/zephyr/guides/modules.html
    - name: zephyr
      repo-path: sdk-zephyr
-      revision: 02718211f9a98f9967eeef14305148483a8bb048
+      revision: pull/2257/head


c5efe1f601490fdb365fb17f28ec33d59409e54f

rlubos · 2024-11-13T09:45:59Z

I'll backport this manually.

rlubos · 2024-11-13T15:42:02Z

@de-nordic The manifest commit should be dropped, sdk-zephyr has already moved forward on main

Set CONFIG_MCUBOOT_BOOTLOADER_USES_SHA512 for application where ED25519 is enabled for MCUboot. Signed-off-by: Dominik Ermel <[email protected]>

de-nordic requested review from a team as code owners November 12, 2024 13:05

de-nordic requested a review from gchwier November 12, 2024 13:05

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 12, 2024

de-nordic requested a review from nvlsianpu November 12, 2024 13:05

NordicBuilder added manifest-zephyr DNM labels Nov 12, 2024

nordicjm reviewed Nov 12, 2024

View reviewed changes

de-nordic force-pushed the fix-mcumgr-sha512 branch from 07c5232 to 21ae0ea Compare November 12, 2024 14:10

nordicjm approved these changes Nov 12, 2024

View reviewed changes

nvlsianpu approved these changes Nov 12, 2024

View reviewed changes

gchwier approved these changes Nov 12, 2024

View reviewed changes

de-nordic force-pushed the fix-mcumgr-sha512 branch from 21ae0ea to 2d9ca54 Compare November 12, 2024 18:52

nvlsianpu added this to the 2.8.0 milestone Nov 12, 2024

nvlsianpu added the backport v2.8-branch auto-create a PR with same commits to v2.8-branch label Nov 12, 2024

rlubos reviewed Nov 13, 2024

View reviewed changes

rlubos removed the backport v2.8-branch auto-create a PR with same commits to v2.8-branch label Nov 13, 2024

rlubos mentioned this pull request Nov 13, 2024

Backport sdk-zephyr and sdk-mcuboot changes (18817 && 18821) #18842

Merged

de-nordic force-pushed the fix-mcumgr-sha512 branch from 2d9ca54 to 6ced8d7 Compare November 13, 2024 14:00

de-nordic requested a review from rlubos November 13, 2024 14:00

NordicBuilder removed the DNM label Nov 13, 2024

sysbuild: Set CONFIG_MCUBOOT_BOOTLOADER_USES_SHA512 with ED25519

86580c9

Set CONFIG_MCUBOOT_BOOTLOADER_USES_SHA512 for application where ED25519 is enabled for MCUboot. Signed-off-by: Dominik Ermel <[email protected]>

de-nordic force-pushed the fix-mcumgr-sha512 branch from 6ced8d7 to 86580c9 Compare November 13, 2024 15:44

github-actions bot removed the manifest label Nov 13, 2024

rlubos approved these changes Nov 13, 2024

View reviewed changes

rlubos merged commit a8ee946 into nrfconnect:main Nov 13, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix MCUmgr support for SHA512 hashed images #18817

Fix MCUmgr support for SHA512 hashed images #18817

de-nordic commented Nov 12, 2024

NordicBuilder commented Nov 12, 2024 •

edited

Loading

NordicBuilder commented Nov 12, 2024 •

edited

Loading

nordicjm left a comment

NordicBuilder commented Nov 12, 2024

NordicBuilder commented Nov 12, 2024 •

edited

Loading

rlubos Nov 13, 2024

rlubos commented Nov 13, 2024

rlubos commented Nov 13, 2024

Fix MCUmgr support for SHA512 hashed images #18817

Fix MCUmgr support for SHA512 hashed images #18817

Conversation

de-nordic commented Nov 12, 2024

NordicBuilder commented Nov 12, 2024 • edited Loading

NordicBuilder commented Nov 12, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

nordicjm left a comment

Choose a reason for hiding this comment

NordicBuilder commented Nov 12, 2024

NordicBuilder commented Nov 12, 2024 • edited Loading

Memory footprint analysis revealed the following potential issues

rlubos Nov 13, 2024

Choose a reason for hiding this comment

rlubos commented Nov 13, 2024

rlubos commented Nov 13, 2024

NordicBuilder commented Nov 12, 2024 •

edited

Loading

NordicBuilder commented Nov 12, 2024 •

edited

Loading

NordicBuilder commented Nov 12, 2024 •

edited

Loading